From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MbFkt-0001WB-Rv
	for qemu-devel@nongnu.org; Wed, 12 Aug 2009 11:28:47 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MbFkp-0001Qp-2U
	for qemu-devel@nongnu.org; Wed, 12 Aug 2009 11:28:47 -0400
Received: from [199.232.76.173] (port=60919 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MbFko-0001QT-PL
	for qemu-devel@nongnu.org; Wed, 12 Aug 2009 11:28:42 -0400
Received: from mx2.redhat.com ([66.187.237.31]:37407)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MbFko-0000kO-Bv
	for qemu-devel@nongnu.org; Wed, 12 Aug 2009 11:28:42 -0400
Message-ID: <4A82DFA3.4090903@redhat.com>
Date: Wed, 12 Aug 2009 17:28:35 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <4A7ADE70.7060204@sgi.com> <4A806D86.8090208@codemonkey.ws>
	<4A8156D4.2090000@sgi.com> <4A817B61.2010803@redhat.com>
	<4A818415.8020706@sgi.com> <4A81D666.2010404@redhat.com>
	<4A82D4E4.90200@sgi.com> <4A82D8B1.7000402@redhat.com>
	<4A82DB7C.6090906@sgi.com>
In-Reply-To: <4A82DB7C.6090906@sgi.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] isa_reserve_irq()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes Sorensen <jes@sgi.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Gleb Natapov <gleb@redhat.com>

On 08/12/09 17:10, Jes Sorensen wrote:
> On 08/12/2009 04:58 PM, Gerd Hoffmann wrote:
>> On 08/12/09 16:42, Jes Sorensen wrote:
>>> Hi Gerd,
>>>
>>> This looks great! I have implemented isa_reserve_irq() on top of this.
>>> It allows one to reserve ISA irqs without converting them to qdev, which
>>> for certain interrupts makes sense,
>>
>> which ones?
>
> ferr

Ah, that one.

>> I think that deserves a comment clearly stating that this interface is a
>> (temporary?) thing for not-yet converted devices.
>>
>> Otherwise it looks fine to me.
>
> If you think it makes sense to convert ferr as well, then I'll be happy
> to add the comment.

Hmm, I don't think it makes sense to pull a dummy device out of thin 
air, isa_reserve_irq() will do fine.  But it should be be clearly 
documented that this is for this special case and not-yet converted 
devices.  qdev-ified devices should use the other isa_*_irq functions 
instead.

cheers,
   Gerd