From: Gerd Hoffmann <kraxel@redhat.com>
To: Jes Sorensen <jes@sgi.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
Gleb Natapov <gleb@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] isa_reserve_irq()
Date: Wed, 12 Aug 2009 17:41:23 +0200 [thread overview]
Message-ID: <4A82E2A3.5060501@redhat.com> (raw)
In-Reply-To: <4A82E06C.8090800@sgi.com>
On 08/12/09 17:31, Jes Sorensen wrote:
> On 08/12/2009 05:28 PM, Gerd Hoffmann wrote:
>> Hmm, I don't think it makes sense to pull a dummy device out of thin
>> air, isa_reserve_irq() will do fine. But it should be be clearly
>> documented that this is for this special case and not-yet converted
>> devices. qdev-ified devices should use the other isa_*_irq functions
>> instead.
>
> Ok - do you want me to update the documentation, or is it fine as is
> then?
Would be great to update the commit message and also place a comment
into the source code.
thanks,
Gerd
next prev parent reply other threads:[~2009-08-12 15:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 13:45 [Qemu-devel] [PATCH] qemu_reserve_isa_irq() Jes Sorensen
2009-08-07 9:13 ` [Qemu-devel] " Gleb Natapov
2009-08-10 18:57 ` [Qemu-devel] " Anthony Liguori
2009-08-11 11:32 ` Jes Sorensen
2009-08-11 14:08 ` Gerd Hoffmann
2009-08-11 14:45 ` Jes Sorensen
2009-08-11 16:16 ` Gerd Hoffmann
2009-08-11 20:36 ` Gerd Hoffmann
2009-08-12 14:42 ` [Qemu-devel] [PATCH] isa_reserve_irq() Jes Sorensen
2009-08-12 14:58 ` [Qemu-devel] " Gerd Hoffmann
2009-08-12 15:10 ` Jes Sorensen
2009-08-12 15:28 ` Gerd Hoffmann
2009-08-12 15:31 ` Jes Sorensen
2009-08-12 15:41 ` Gerd Hoffmann [this message]
2009-08-12 15:41 ` [Qemu-devel] [PATCH] isa_reserve_irq() v4 Jes Sorensen
2009-08-12 15:55 ` [Qemu-devel] " Gerd Hoffmann
2009-08-14 8:55 ` Gerd Hoffmann
2009-08-12 15:18 ` [Qemu-devel] Re: [PATCH] isa_reserve_irq() Jes Sorensen
2009-08-14 8:40 ` [Qemu-devel] [PATCH] qemu_reserve_isa_irq() Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A82E2A3.5060501@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=gleb@redhat.com \
--cc=jes@sgi.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).