qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 02/29] Introduce QInt
Date: Thu, 13 Aug 2009 16:55:50 +0300	[thread overview]
Message-ID: <4A841B66.4000907@redhat.com> (raw)
In-Reply-To: <1250171428-29308-3-git-send-email-lcapitulino@redhat.com>

On 08/13/2009 04:50 PM, Luiz Capitulino wrote:
> +
> +/**
> + * qobject_to_qint(): Convert a QObject into a QInt
> + */
> +static inline QInt *qobject_to_qint(const QObject *obj)
> +{
> +    return container_of(obj, QInt, base);
> +}
> +
>    

It's worthwhile to check the type here and return NULL if not an 
integer.  That allows users to

    QInt *qi = qobject_to_qint(...);

    if (qi) {
        do something
    } else {
        error handling
    }

(this is equivalent to C++'s static_cast vs. dynamic_cast)

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2009-08-13 13:56 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-13 13:49 [Qemu-devel] [PATCH v0 00/29] QMonitor Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 01/29] Introduce QObject Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 02/29] Introduce QInt Luiz Capitulino
2009-08-13 13:55   ` Avi Kivity [this message]
2009-08-13 14:16     ` [Qemu-devel] " Luiz Capitulino
2009-08-13 14:43       ` Avi Kivity
2009-08-13 13:50 ` [Qemu-devel] [PATCH 03/29] Introduce QString Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 04/29] Introduce QDict Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 05/29] Add wrappers to functions used by the Monitor Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 06/29] monitor: New format for handlers argument types Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 07/29] monitor: Setup a QDict with arguments to handlers Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 08/29] monitor: Export QDict header Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 09/29] monitor: Port handler_0 to use QDict Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 10/29] monitor: Port handler_1 " Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 11/29] monitor: Port handler_2 " Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 12/29] monitor: Port handler_3 " Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 13/29] monitor: Port handler_4 " Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 14/29] monitor: Port handler_5 " Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 15/29] monitor: Port handler_6 " Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 16/29] monitor: Port handler_7 " Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 17/29] monitor: Drop handler_8 and handler_9 Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 18/29] monitor: Port handler_10 to use QDict Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 19/29] monitor: Split monitor_handle_command() Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 20/29] monitor: Drop unused macros Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 21/29] monitor: Drop str_allocated[] Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 22/29] monitor: Drop args[] handling code Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 23/29] monitor: fail when 'i' type is greater than 32-bit Luiz Capitulino
2009-08-13 13:59   ` [Qemu-devel] " Avi Kivity
2009-08-13 14:18     ` Luiz Capitulino
2009-08-13 14:43       ` Avi Kivity
2009-08-13 13:50 ` [Qemu-devel] [PATCH 24/29] monitor: Update supported types documentation Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 25/29] Add check support Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 26/29] Introduce QInt unit-tests Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 27/29] Introduce QString unit-tests Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 28/29] Introduce QDict test data file Luiz Capitulino
2009-08-13 13:50 ` [Qemu-devel] [PATCH 29/29] Introduce QDict unit-tests Luiz Capitulino
  -- strict thread matches above, loose matches on Subject: below --
2009-08-19 23:07 [Qemu-devel] [PATCH v1 00/29] QMonitor Luiz Capitulino
2009-08-19 23:07 ` [Qemu-devel] [PATCH 02/29] Introduce QInt Luiz Capitulino
2009-08-20  7:51   ` [Qemu-devel] " Avi Kivity
2009-08-20  9:22     ` Paolo Bonzini
2009-08-20 13:24     ` Luiz Capitulino
2009-08-20 13:26       ` Avi Kivity
2009-08-20 14:51         ` Luiz Capitulino
2009-08-20 14:55           ` Avi Kivity
2009-08-20 15:14             ` Luiz Capitulino
2009-08-20  8:37   ` Paolo Bonzini
2009-08-20 13:44     ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A841B66.4000907@redhat.com \
    --to=avi@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).