From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MbfWr-0004dA-5C
	for qemu-devel@nongnu.org; Thu, 13 Aug 2009 15:00:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MbfWm-0004cS-L0
	for qemu-devel@nongnu.org; Thu, 13 Aug 2009 15:00:00 -0400
Received: from [199.232.76.173] (port=58395 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MbfWm-0004cP-GT
	for qemu-devel@nongnu.org; Thu, 13 Aug 2009 14:59:56 -0400
Received: from mail-qy0-f174.google.com ([209.85.221.174]:45547)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MbfWl-00066r-Vi
	for qemu-devel@nongnu.org; Thu, 13 Aug 2009 14:59:56 -0400
Received: by qyk4 with SMTP id 4so769869qyk.4
	for <qemu-devel@nongnu.org>; Thu, 13 Aug 2009 11:59:54 -0700 (PDT)
Message-ID: <4A8462A8.1020206@codemonkey.ws>
Date: Thu, 13 Aug 2009 13:59:52 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] save/restore broken?
References: <h5s6sk$ema$1@ger.gmane.org> <20090813154827.409ed832@doriath>
In-Reply-To: <20090813154827.409ed832@doriath>
Content-Type: multipart/mixed; boundary="------------030104070506070501080502"
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Paolo Bonzini <bonzini@gnu.org>, qemu-devel@nongnu.org, gleb@redhat.com

This is a multi-part message in MIME format.
--------------030104070506070501080502
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Luiz Capitulino wrote:
> On Tue, 11 Aug 2009 18:39:47 +0200
> Paolo Bonzini <bonzini@gnu.org> wrote:
>
>   
>> Hi all,
>>
>> if I try to save and restore an image using current qemu and current 
>> libvirt, the load fails.
>>     
>
>  Yes, it's broken. I'm unable to loadvm and to migrate.
>
>  According to git bisect the problem was introduced by:
This should fix it.

Regards,

Anthony Liguori

--------------030104070506070501080502
Content-Type: text/x-patch;
 name="ide-migration.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="ide-migration.patch"

commit a536948b3805a311f274b119c5202fdc86504cf3
Author: Anthony Liguori <aliguori@us.ibm.com>
Date:   Thu Aug 13 13:58:21 2009 -0500

    Fix migration for ide devices
    
    commit 93c8cfd9e67a62711b86f4c93747566885eb7928
    Author: Gleb Natapov <gleb@redhat.com>
    Date:   Sun Aug 2 11:36:47 2009 +0300
    
        make windows notice media change
    
    Broke save/restore by loading a new field but not saving it.
    
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

diff --git a/hw/ide.c b/hw/ide.c
index bebda7c..1e38ae3 100644
--- a/hw/ide.c
+++ b/hw/ide.c
@@ -2888,6 +2888,7 @@ static void ide_save(QEMUFile* f, IDEState *s)
 
     qemu_put_8s(f, &s->sense_key);
     qemu_put_8s(f, &s->asc);
+    qemu_put_8s(f, &s->cdrom_changed);
     /* XXX: if a transfer is pending, we do not save it yet */
 }
 

--------------030104070506070501080502--