From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MbxAN-0003eT-72 for qemu-devel@nongnu.org; Fri, 14 Aug 2009 09:49:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MbxAI-0003Xv-5E for qemu-devel@nongnu.org; Fri, 14 Aug 2009 09:49:58 -0400 Received: from [199.232.76.173] (port=48027 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MbxAH-0003Xm-UR for qemu-devel@nongnu.org; Fri, 14 Aug 2009 09:49:54 -0400 Received: from mx2.redhat.com ([66.187.237.31]:55443) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MbxAH-0002O4-Gv for qemu-devel@nongnu.org; Fri, 14 Aug 2009 09:49:53 -0400 Message-ID: <4A856B5E.2000303@redhat.com> Date: Fri, 14 Aug 2009 15:49:18 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: virtio-serial: An interface for host-guest communication References: <20090806173740.GA1178@shareable.org> <20090807063800.GA16769@amit-x200.redhat.com> <4A7C36D3.3040305@codemonkey.ws> <20090810065508.GA4499@amit-x200.redhat.com> <4A7FECCA.8080804@redhat.com> <4A801A7B.1020208@codemonkey.ws> <4A80287C.7050400@redhat.com> <4A802CA7.9020701@codemonkey.ws> <4A803E07.7080407@redhat.com> <4A8051F3.7040400@codemonkey.ws> <20090814081518.GA7418@amit-x200.redhat.com> In-Reply-To: <20090814081518.GA7418@amit-x200.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: Rusty Russell , virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, qemu-devel@nongnu.org On 08/14/09 10:15, Amit Shah wrote: > The guest code sort-of ends up looking like this after merging > virtio_console into virtio_serial. I think it should better go the other way around: add multichannel support to virtio-concole, probably guarded by a feature flag so old host+new guest and new host+old guest combinations continue to work. > Since there's support for only one console as of now, I've assigned port > #2 as the console port so that we hook into hvc when a port is found at > that location. Doesn't sound like this is going to be backward compatible ... Also I still think passing a 'protocol' string for each port is a good idea, so you can stick that into a sysfs file for guests use. Note it is probably easy to make virtio-console support multiple hvc lines by having one protocol for that (named 'console' for example). cheers, Gerd