From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1McCir-0006le-RA
	for qemu-devel@nongnu.org; Sat, 15 Aug 2009 02:26:37 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1McCim-0006c5-34
	for qemu-devel@nongnu.org; Sat, 15 Aug 2009 02:26:36 -0400
Received: from [199.232.76.173] (port=58842 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1McCim-0006bn-0I
	for qemu-devel@nongnu.org; Sat, 15 Aug 2009 02:26:32 -0400
Received: from li2-213.members.linode.com ([69.56.173.213]:58928
	helo=mail.zilogic.com) by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <vijaykumar@bravegnu.org>) id 1McCil-0002PD-ME
	for qemu-devel@nongnu.org; Sat, 15 Aug 2009 02:26:31 -0400
Message-ID: <4A8654AD.2020003@bravegnu.org>
Date: Sat, 15 Aug 2009 11:54:45 +0530
From: Vijay Kumar <vijaykumar@bravegnu.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Implement RCC2 in Stellaris
References: <4A840286.5050409@bravegnu.org>
	<58BD0469C48A7443A479A13D101685E302E2EACF@ala-mail09.corp.ad.wrs.com>
In-Reply-To: <58BD0469C48A7443A479A13D101685E302E2EACF@ala-mail09.corp.ad.wrs.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Krumme, Chris" <Chris.Krumme@windriver.com>
Cc: qemu-devel@nongnu.org, paul@codesourcery.com

Krumme, Chris wrote:
>>      ssys_state *s = (ssys_state *)opaque;
>>  
>> -    if (version_id != 1)
>> +    if (version_id != 2)
>>          return -EINVAL;
>>  
>>      s->pborctl = qemu_get_be32(f);
>> @@ -638,6 +703,7 @@ static int ssys_load(QEMUFile *f, void 
>> *opaque, int version_id)
>>      s->int_status = qemu_get_be32(f);
>>      s->resc = qemu_get_be32(f);
>>      s->rcc = qemu_get_be32(f);
>> +    s->rcc2 = qemu_get_be32(f);
> 
> If I understand correctly this should be protected by an if (version ==
> 2), and the if above should support both 1 and 2.
> 
> This does not seem like a change that should break old --> new
> migration.

Thanks for the suggestion Chris. I will incorporate this and
send the updated patch.

Regards,
Vijay