From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mcyv2-0002wy-VB for qemu-devel@nongnu.org; Mon, 17 Aug 2009 05:54:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mcyux-0002w2-OJ for qemu-devel@nongnu.org; Mon, 17 Aug 2009 05:54:24 -0400 Received: from [199.232.76.173] (port=55492 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mcyux-0002vz-HT for qemu-devel@nongnu.org; Mon, 17 Aug 2009 05:54:19 -0400 Received: from mx2.redhat.com ([66.187.237.31]:59480) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mcyuw-0002dn-HK for qemu-devel@nongnu.org; Mon, 17 Aug 2009 05:54:19 -0400 Message-ID: <4A8928C7.1040807@redhat.com> Date: Mon, 17 Aug 2009 12:54:15 +0300 From: Avi Kivity MIME-Version: 1.0 References: <20090817022024.GE1025@MAIL.13thfloor.at> In-Reply-To: <20090817022024.GE1025@MAIL.13thfloor.at> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: i8259 defaults wrong? List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kvm@vger.kernel.org, qemu-devel@nongnu.org On 08/17/2009 05:20 AM, Herbert Poetzl wrote: > Greetings! > > looking at the i8259 implementation found in qemu > as well as in the in-kernel kvm implementation, I > see that on pic_reset() special_fully_nested_mode > is set to zero, but the intel(r) 8259A manual says > on page 15: > > Fully Nested Mode > > This mode is entered after initialization unless > another mode is programmed. > > any comments are appreciated, a patch should be > trivial, but I'd gladly submit one if requested. > > Well, does the BIOS set fully nested mode on reset? If not, a kvm change is difficult, since the bios and kvm are updated independently. -- error compiling committee.c: too many arguments to function