From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MdP9S-00040y-IX for qemu-devel@nongnu.org; Tue, 18 Aug 2009 09:55:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MdP9N-0003wY-Tv for qemu-devel@nongnu.org; Tue, 18 Aug 2009 09:55:01 -0400 Received: from [199.232.76.173] (port=33719 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MdP9N-0003wR-6Z for qemu-devel@nongnu.org; Tue, 18 Aug 2009 09:54:57 -0400 Received: from mx2.redhat.com ([66.187.237.31]:53925) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MdP9M-0004bi-Kg for qemu-devel@nongnu.org; Tue, 18 Aug 2009 09:54:56 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7IDstA4006443 for ; Tue, 18 Aug 2009 09:54:55 -0400 Message-ID: <4A8AB2AC.2050703@redhat.com> Date: Tue, 18 Aug 2009 15:54:52 +0200 From: Chris Lalancette MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] unify popen/fopen qemu wrappers References: <1250079455-24416-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1250079455-24416-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Paolo Bonzini wrote: > While reading Chris's code for fd migration I noticed the duplication > between QEMUFilePopen and QEMUFileStdio. This fixes it, and makes > qemu_fopen more similar qemu_popen. I finally got around to testing this, along with Paolo's upcoming re-post of the migration-fd stuff, and it seems to work fine for me, and is a nice cleanup. > Signed-off-by: Paolo Bonzini Acked-by: Chris Lalancette