From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mdkr3-0007oG-Pr
	for qemu-devel@nongnu.org; Wed, 19 Aug 2009 09:05:29 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mdkqz-0007my-6z
	for qemu-devel@nongnu.org; Wed, 19 Aug 2009 09:05:29 -0400
Received: from [199.232.76.173] (port=47509 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mdkqz-0007mv-1V
	for qemu-devel@nongnu.org; Wed, 19 Aug 2009 09:05:25 -0400
Received: from [66.187.237.31] (port=55727 helo=mx2.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Mdkqy-0000co-CB
	for qemu-devel@nongnu.org; Wed, 19 Aug 2009 09:05:24 -0400
Message-ID: <4A8BF88D.9020302@redhat.com>
Date: Wed, 19 Aug 2009 15:05:17 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1250611607-2441-1-git-send-email-kraxel@redhat.com>	<1250611607-2441-6-git-send-email-kraxel@redhat.com>
	<m34os4qfv2.fsf@neno.mitica>
In-Reply-To: <m34os4qfv2.fsf@neno.mitica>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 5/8] ide: split away ide-macio.c
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@trasno.org>
Cc: qemu-devel@nongnu.org

On 08/19/09 12:04, Juan Quintela wrote:
> Reviewed-by: Juan Quintela<quintela@redhat.com>
>
> Reply-to: quintela@redhat.com
> Gerd Hoffmann<kraxel@redhat.com>  wrote:
>> create ide-macio.c and place macio support there.
>> only build ide-macio support for platforms using it.
>
> This patches does two things.
>
> split ide-macio.c
> Move losts of constants from ide.c to ide-internal.h
>
> I agree with both changes, just noticing that they are doing two things
> here.  Consider to split the changeset if you have to resend the series
> for any reason.  I like the change :)

I've moved things from ide.c to ide-internal.h as needed.  Probably 
better to have a separate patch which creates the final ide-internal.h 
version instead, will fix for the next version (and also the comments ...).

cheers,
   Gerd