[Qemu-devel] Re: [PATCH 02/29] Introduce QInt

[Paolo Bonzini <bonzini@gnu.org>]

On 08/20/2009 01:07 AM, Luiz Capitulino wrote:
> QInt is a high-level data type that can be used to store integers
> and perform type-safe conversions.
>
> The following functions are available:
>
> - qint_from_int()   Create a new QInt from an int
> - qint_from_int64() Create a new QInt from an int64_t
> - qint_to_int()     Export QInt to int
> - qint_to_uint64()  Export QInt to uint64_t
> - qint_to_uint32()  Export QInt to uint32_t
>
> Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com>
> ---
>   Makefile  |    1 +
>   qint.c    |   92 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   qint.h    |   20 +++++++++++++

I don't see the need for a separate header file since 99.99% of the 
QObject clients would include all the .h files; also, most function 
could be inline in qint.h (or qobject.h) given that struct QInt is not 
opaque.

I also noticed this from 01/29 only now:

+#define QType_HEAD  \
+    QObject base;

remove the trailing semicolon to ease automatic indentation in editors.

Paolo