From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Me3CP-00016K-DP
	for qemu-devel@nongnu.org; Thu, 20 Aug 2009 04:40:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Me3CK-00015i-Gd
	for qemu-devel@nongnu.org; Thu, 20 Aug 2009 04:40:44 -0400
Received: from [199.232.76.173] (port=52858 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Me3CK-00015Z-5T
	for qemu-devel@nongnu.org; Thu, 20 Aug 2009 04:40:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28131)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1Me3CJ-00020V-Mq
	for qemu-devel@nongnu.org; Thu, 20 Aug 2009 04:40:40 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7K8ebgr008836
	for <qemu-devel@nongnu.org>; Thu, 20 Aug 2009 04:40:37 -0400
Message-ID: <4A8D0C00.6080402@redhat.com>
Date: Thu, 20 Aug 2009 11:40:32 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 6/6] Continue a migrated vm is a bad idea
References: <cover.1250646771.git.quintela@redhat.com>
	<927bb26f5425c58febd666db8fec67f55a229b5c.1250646771.git.quintela@redhat.com>
In-Reply-To: <927bb26f5425c58febd666db8fec67f55a229b5c.1250646771.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On 08/19/2009 05:07 AM, Juan Quintela wrote:
> index ea5c33a..762a9a5 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -567,6 +567,11 @@ static void do_cont(Monitor *mon)
>   {
>       struct bdrv_iterate_context context = { mon, 0 };
>
> +    if (unlikely(vm_has_migrated)) {
> +        monitor_printf(mon, "this vm has migrated to other machine\n");
> +        monitor_printf(mon, "You have to load other vm\n");
> +        return;
> +    }
>    

You don't know whether the guest is running on the other side.  It may 
be that the control program started the other side stopped, and after 
migration completes decides which side to continue running.

-- 
error compiling committee.c: too many arguments to function