From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MeORx-0003M8-Px for qemu-devel@nongnu.org; Fri, 21 Aug 2009 03:22:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MeORs-0003LO-VQ for qemu-devel@nongnu.org; Fri, 21 Aug 2009 03:22:12 -0400 Received: from [199.232.76.173] (port=50596 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeORs-0003LL-R4 for qemu-devel@nongnu.org; Fri, 21 Aug 2009 03:22:08 -0400 Received: from mx20.gnu.org ([199.232.41.8]:33427) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MeORs-0005lm-93 for qemu-devel@nongnu.org; Fri, 21 Aug 2009 03:22:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MeORq-0004FC-RQ for qemu-devel@nongnu.org; Fri, 21 Aug 2009 03:22:07 -0400 Message-ID: <4A8E4B0B.90506@redhat.com> Date: Fri, 21 Aug 2009 09:21:47 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 02/10] ide: split away ide-internal.h References: <1250774546-18951-1-git-send-email-kraxel@redhat.com> <1250774546-18951-3-git-send-email-kraxel@redhat.com> <48922F65-A4B8-4801-A344-D53799C24119@claunia.com> In-Reply-To: <48922F65-A4B8-4801-A344-D53799C24119@claunia.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Natalia Portillo Cc: qemu-devel@nongnu.org On 08/21/09 01:40, Natalia Portillo wrote: > I don't see the sense for this line. Current code uses this. I'm just moving all these defines from ide.c to ide-internal.h. cheers, Gerd