From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MePYR-0006zN-AR for qemu-devel@nongnu.org; Fri, 21 Aug 2009 04:32:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MePYL-0006z5-Oa for qemu-devel@nongnu.org; Fri, 21 Aug 2009 04:32:57 -0400 Received: from [199.232.76.173] (port=47379 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MePYL-0006z2-HK for qemu-devel@nongnu.org; Fri, 21 Aug 2009 04:32:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24502) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MePYL-0007W8-1i for qemu-devel@nongnu.org; Fri, 21 Aug 2009 04:32:53 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7L8Woke000916 for ; Fri, 21 Aug 2009 04:32:50 -0400 Message-ID: <4A8E5BAB.4070409@redhat.com> Date: Fri, 21 Aug 2009 10:32:43 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 16/23] Port PCI Bus to VMState design References: <101b7fd66dd59c7655b257eb8dd438175f5232b6.1250788880.git.quintela@redhat.com> In-Reply-To: <101b7fd66dd59c7655b257eb8dd438175f5232b6.1250788880.git.quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org On 08/20/09 19:42, Juan Quintela wrote: > This uses VARRAY and INT32_EQUAL values This is one place where I would change the code to reduce load/save complexity. Quick grep shows that the max value for bus->nirqs is 32. s/*irq_count/irq_count[32]/ for PCIBus, drop dynamic allocation and allways save/load 32 values. INT32_EQUAL + VARRAY isn't needed then. cheers, Gerd