From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MePrh-0005Dc-JL
	for qemu-devel@nongnu.org; Fri, 21 Aug 2009 04:52:53 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MePrd-0005Ac-0W
	for qemu-devel@nongnu.org; Fri, 21 Aug 2009 04:52:53 -0400
Received: from [199.232.76.173] (port=56729 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MePrc-0005AQ-B0
	for qemu-devel@nongnu.org; Fri, 21 Aug 2009 04:52:48 -0400
Received: from mail-ew0-f223.google.com ([209.85.219.223]:53023)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paolo.bonzini@gmail.com>) id 1MePrb-0002E7-L4
	for qemu-devel@nongnu.org; Fri, 21 Aug 2009 04:52:48 -0400
Received: by ewy23 with SMTP id 23so597553ewy.8
	for <qemu-devel@nongnu.org>; Fri, 21 Aug 2009 01:52:45 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4A8E605B.4050807@gnu.org>
Date: Fri, 21 Aug 2009 10:52:43 +0200
From: Paolo Bonzini <bonzini@gnu.org>
MIME-Version: 1.0
References: <cover.1250810973.git.quintela@redhat.com>
	<8321db3e7d3b04a58a07b77256f5c11fad54c1dd.1250810973.git.quintela@redhat.com>
In-Reply-To: <8321db3e7d3b04a58a07b77256f5c11fad54c1dd.1250810973.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 03/14] configure stellaris device only for
	arm softmmu
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org


>   # What drivers should we compile
>   ssi_bus=no
> +stellaris=no

What about calling these CONFIG_SSI CONFIG_STELLARIS etc. already in 
configure, and initializing them with

: ${CONFIG_SSI=n}
: ${CONFIG_STELLARIS=n}

> @@ -2236,6 +2238,10 @@ if test "$ssi_bus" = "yes" ; then
>       echo "CONFIG_SSI=y">>  $config_host_mak
>   fi
>
> +if test "$stellaris" = "yes" ; then
> +    echo "CONFIG_STELLARIS=y">>  $config_host_mak
> +fi

Then you can:

1) save duplication using

for i in CONFIG_SSI CONFIG_STELLARIS; do
   case \$$i in
   if test "$config_var" = y; then
     echo "$i=y">> $config_host_mak
   fi
done

2) allow the user to force your choice by setting environment variables 
when calling configure (not sure how useful this is).

Otherwise, looks nice!

Paolo