From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MePxt-0000nz-7n for qemu-devel@nongnu.org; Fri, 21 Aug 2009 04:59:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MePxo-0000iK-5T for qemu-devel@nongnu.org; Fri, 21 Aug 2009 04:59:16 -0400 Received: from [199.232.76.173] (port=45189 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MePxn-0000hx-DQ for qemu-devel@nongnu.org; Fri, 21 Aug 2009 04:59:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4988) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MePxm-0003Z7-RP for qemu-devel@nongnu.org; Fri, 21 Aug 2009 04:59:11 -0400 Received: from int-mx06.intmail.prod.int.phx2.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.19]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7L8x9Ne005272 for ; Fri, 21 Aug 2009 04:59:09 -0400 Message-ID: <4A8E61D1.80003@redhat.com> Date: Fri, 21 Aug 2009 10:58:57 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 00/23] New VMState table based load/save infrastructure References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org On 08/20/09 19:42, Juan Quintela wrote: > - i440fx_load() > Can we put pci_irq_levels[] array in any struct? This is the only driver > that I have found that uses a global variable. Gerd, can you take a look? > It is not possible to have the PCIDevice struct inside a PIIXDevice or similar? Stuffing a pointer to pci_irq_levels into a struct should work without problems and should be good enougth to get vmstate save/load going ;) Sticking the array itself into a struct would be even better, that might need more cleanup work though. cheers, Gerd