From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MeR25-0005ih-LR
	for qemu-devel@nongnu.org; Fri, 21 Aug 2009 06:07:41 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MeR20-0005iP-IK
	for qemu-devel@nongnu.org; Fri, 21 Aug 2009 06:07:40 -0400
Received: from [199.232.76.173] (port=41681 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MeR20-0005iM-CL
	for qemu-devel@nongnu.org; Fri, 21 Aug 2009 06:07:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26054)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MeR1z-0005O5-O3
	for qemu-devel@nongnu.org; Fri, 21 Aug 2009 06:07:36 -0400
Received: from int-mx06.intmail.prod.int.phx2.redhat.com
	(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.19])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7LA7W7x010222
	for <qemu-devel@nongnu.org>; Fri, 21 Aug 2009 06:07:32 -0400
Message-ID: <4A8E71D8.7070106@redhat.com>
Date: Fri, 21 Aug 2009 12:07:20 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <cover.1250788880.git.quintela@redhat.com>	<20ca5615c8cdc456296698133e3b0dbd5a1f4de7.1250788880.git.quintela@redhat.com>	<4A8E6049.6020609@redhat.com>
	<m33a7ly1zl.fsf@neno.mitica>	<4A8E657D.4040604@redhat.com>
	<m3fxblwm3m.fsf@neno.mitica>
In-Reply-To: <m3fxblwm3m.fsf@neno.mitica>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 21/23] Port PCIDevice state to VMState
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On 08/21/09 11:30, Juan Quintela wrote:
> I am talking about virtio_load() actually. How do you translate this to
> a table?

Oh yea, that is nasty.

> int virtio_load(VirtIODevice *vdev, QEMUFile *f)
> {
>      int num, i, ret;
>
>      if (vdev->binding->load_config) {
>          ret = vdev->binding->load_config(vdev->binding_opaque, f);
>          if (ret)
>              return ret;
>      }

Hmm.  Move register_savevm from virtio.c to virtio_pci.c?

Then have virtio_load_pci() which basically calls pci_device_save() + 
virtio_common_save() and kill this binding indirection.

Note: There are non-pci virtio bindings somewhere in qemu.

cheers,
   Gerd