From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MeT2j-0006KY-5y for qemu-devel@nongnu.org; Fri, 21 Aug 2009 08:16:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MeT2e-0006Ix-3x for qemu-devel@nongnu.org; Fri, 21 Aug 2009 08:16:28 -0400 Received: from [199.232.76.173] (port=45475 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeT2d-0006Ir-OH for qemu-devel@nongnu.org; Fri, 21 Aug 2009 08:16:23 -0400 Received: from mx20.gnu.org ([199.232.41.8]:48859) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MeT2d-0003k3-1w for qemu-devel@nongnu.org; Fri, 21 Aug 2009 08:16:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MeT2c-0001Fn-7S for qemu-devel@nongnu.org; Fri, 21 Aug 2009 08:16:22 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7LCGKNd012069 for ; Fri, 21 Aug 2009 08:16:20 -0400 Message-ID: <4A8E9011.7020306@redhat.com> Date: Fri, 21 Aug 2009 14:16:17 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Remove unneded ac97 indirection accessing its state References: <1250855769-24590-1-git-send-email-quintela@redhat.com> In-Reply-To: <1250855769-24590-1-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org > typedef struct AC97LinkState { > - PCIDevice *pci_dev; > + PCIDevice dev; > QEMUSoundCard card; > uint32_t glob_cnt; > uint32_t glob_sta; > -typedef struct PCIAC97LinkState { > - PCIDevice dev; > - AC97LinkState ac97; > -} PCIAC97LinkState; Nice cleanup. Acked-by: Gerd Hoffmann cheers, Gerd