From: Gerd Hoffmann <kraxel@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] qdev: convert watchdogs
Date: Fri, 21 Aug 2009 15:07:15 +0200 [thread overview]
Message-ID: <4A8E9C03.1030907@redhat.com> (raw)
In-Reply-To: <1250843494-28326-4-git-send-email-armbru@redhat.com>
> +static void wdt_ib700_init(ISADevice *dev)
> {
> + timer = qemu_new_timer(vm_clock, ib700_timer_expired, NULL);
> register_savevm("ib700_wdt", -1, 0, ib700_save, ib700_load, NULL);
> -
> register_ioport_write(0x441, 2, 1, ib700_write_disable_reg, NULL);
> register_ioport_write(0x443, 2, 1, ib700_write_enable_reg, NULL);
> }
One minor nit: Setting dev->iobase[] to { 0x441, 0x443 } here would be
nice as 'info qtree' will show the ports actually used by the device then.
Otherwise the patch series looks good.
cheers,
Gerd
next prev parent reply other threads:[~2009-08-21 13:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 8:31 [Qemu-devel] [PATCH 0/3] qdev: clean up & convert watchdogs Markus Armbruster
2009-08-21 8:31 ` [Qemu-devel] [PATCH 1/3] Move watchdog, watchdog_action, give them internal linkage Markus Armbruster
2009-08-21 8:31 ` [Qemu-devel] [PATCH 2/3] Clean up upcast from PCIDevice to I6300State Markus Armbruster
[not found] ` <m3ws4xt7up.fsf@neno.mitica>
2009-08-24 8:49 ` [Qemu-devel] container_of() vs DO_UPCAST() (was: [PATCH 2/3] Clean up upcast from PCIDevice to I6300State) Markus Armbruster
2009-08-24 11:55 ` Paul Brook
2009-08-24 11:59 ` [Qemu-devel] [PATCH 2/3] Clean up upcast from PCIDevice to I6300State Paul Brook
2009-08-24 13:44 ` Markus Armbruster
2009-08-24 15:07 ` Gerd Hoffmann
2009-08-21 8:31 ` [Qemu-devel] [PATCH 3/3] qdev: convert watchdogs Markus Armbruster
2009-08-21 13:07 ` Gerd Hoffmann [this message]
2009-08-24 9:05 ` Immutable qdev properties (was: [Qemu-devel] [PATCH 3/3] qdev: convert watchdogs) Markus Armbruster
2009-08-24 12:25 ` [Qemu-devel] Re: Immutable qdev properties Gerd Hoffmann
2009-08-24 13:04 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8E9C03.1030907@redhat.com \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).