From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MeTq0-00056x-Uf
	for qemu-devel@nongnu.org; Fri, 21 Aug 2009 09:07:24 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MeTpw-00052A-FF
	for qemu-devel@nongnu.org; Fri, 21 Aug 2009 09:07:24 -0400
Received: from [199.232.76.173] (port=58997 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MeTpw-00051s-5H
	for qemu-devel@nongnu.org; Fri, 21 Aug 2009 09:07:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1027)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MeTpv-0007X8-JB
	for qemu-devel@nongnu.org; Fri, 21 Aug 2009 09:07:19 -0400
Received: from int-mx07.intmail.prod.int.phx2.redhat.com
	(int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.20])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7LD7InO019865
	for <qemu-devel@nongnu.org>; Fri, 21 Aug 2009 09:07:18 -0400
Message-ID: <4A8E9C03.1030907@redhat.com>
Date: Fri, 21 Aug 2009 15:07:15 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/3] qdev: convert watchdogs
References: <1250843494-28326-1-git-send-email-armbru@redhat.com>
	<1250843494-28326-4-git-send-email-armbru@redhat.com>
In-Reply-To: <1250843494-28326-4-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org


> +static void wdt_ib700_init(ISADevice *dev)
>   {
> +    timer = qemu_new_timer(vm_clock, ib700_timer_expired, NULL);
>       register_savevm("ib700_wdt", -1, 0, ib700_save, ib700_load, NULL);
> -
>       register_ioport_write(0x441, 2, 1, ib700_write_disable_reg, NULL);
>       register_ioport_write(0x443, 2, 1, ib700_write_enable_reg, NULL);
>   }

One minor nit:  Setting dev->iobase[] to { 0x441, 0x443 } here would be 
nice as 'info qtree' will show the ports actually used by the device then.

Otherwise the patch series looks good.

cheers,
   Gerd