From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MfYnN-000108-Qr
	for qemu-devel@nongnu.org; Mon, 24 Aug 2009 08:37:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MfYnJ-0000v2-1g
	for qemu-devel@nongnu.org; Mon, 24 Aug 2009 08:37:09 -0400
Received: from [199.232.76.173] (port=52339 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MfYnI-0000uz-Q1
	for qemu-devel@nongnu.org; Mon, 24 Aug 2009 08:37:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15073)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MfYnI-0006IX-8S
	for qemu-devel@nongnu.org; Mon, 24 Aug 2009 08:37:04 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7OCb2UA009192
	for <qemu-devel@nongnu.org>; Mon, 24 Aug 2009 08:37:02 -0400
Message-ID: <4A92896C.2050808@redhat.com>
Date: Mon, 24 Aug 2009 14:37:00 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 00/22] Indirection Cleanup
References: <cover.1251111439.git.quintela@redhat.com>
In-Reply-To: <cover.1251111439.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On 08/24/09 13:03, Juan Quintela wrote:
> This patch series clean up "half" converted qemu drivers that had changed from:
>
> struct FOOState
>
> to
>
> typedef PCIFOOState {
>      PCIDevice dev;
>      FOOState foo;
> } PCIFOOState;
>
> It just moves PCIDevice to be the 1st field of FOOState.

Note that there are a bunch of cases where it actually makes sense to 
have PCIFOOState because foo can be connected to different busses and 
thus there is a ISAFOOState (or will be once ISA is qdevified too).

Disclaimer: did't look through the patches yet, just scanned the 
subjects.  But I've seen ne2000 + vga on the list.  For both devices ISA 
variants exist.  Likewise OHCI, there are also non-PCI variants.

> - pcnet:  It needs a different approach, because it can be both a PCIDevice
>    or a SysBus device.

That one too ;)
Why do you want to change it?

cheers,
   Gerd