From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MfYqi-0005Do-2R
	for qemu-devel@nongnu.org; Mon, 24 Aug 2009 08:40:36 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MfYqd-0005BJ-AR
	for qemu-devel@nongnu.org; Mon, 24 Aug 2009 08:40:35 -0400
Received: from [199.232.76.173] (port=52374 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MfYqd-0005B7-1O
	for qemu-devel@nongnu.org; Mon, 24 Aug 2009 08:40:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9009)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MfYqc-0006i6-C3
	for qemu-devel@nongnu.org; Mon, 24 Aug 2009 08:40:30 -0400
Received: from int-mx03.intmail.prod.int.phx2.redhat.com
	(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7OCeT2F014518
	for <qemu-devel@nongnu.org>; Mon, 24 Aug 2009 08:40:29 -0400
Message-ID: <4A928A3B.4090207@redhat.com>
Date: Mon, 24 Aug 2009 14:40:27 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 07/22] ne2000: Remove unneeded
	double	indirection of PCINE2000State
References: <cover.1251111439.git.quintela@redhat.com>
	<9052e745819c03d86640f258f86e2a5e9424d55c.1251111439.git.quintela@redhat.com>
In-Reply-To: <9052e745819c03d86640f258f86e2a5e9424d55c.1251111439.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

>   typedef struct NE2000State {
> +    PCIDevice dev;
>       uint8_t cmd;

> -typedef struct PCINE2000State {
> -    PCIDevice dev;
> -    NE2000State ne2000;
> -} PCINE2000State;

NACK.

We'll have a ...

typedef struct ISANE2000State {
    ISADevice dev;
    NE2000State ne2000;
} ISANE2000State;

... some day.

cheers,
   Gerd