From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MfZxP-0007jC-Dz for qemu-devel@nongnu.org; Mon, 24 Aug 2009 09:51:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MfZxK-0007dX-7t for qemu-devel@nongnu.org; Mon, 24 Aug 2009 09:51:34 -0400 Received: from [199.232.76.173] (port=40754 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MfZxJ-0007dS-Ss for qemu-devel@nongnu.org; Mon, 24 Aug 2009 09:51:30 -0400 Received: from qw-out-1920.google.com ([74.125.92.150]:37014) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MfZxJ-0002g1-JY for qemu-devel@nongnu.org; Mon, 24 Aug 2009 09:51:29 -0400 Received: by qw-out-1920.google.com with SMTP id 5so1204289qwc.4 for ; Mon, 24 Aug 2009 06:51:29 -0700 (PDT) Message-ID: <4A929ADE.4000007@codemonkey.ws> Date: Mon, 24 Aug 2009 08:51:26 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 02/22] eepro100: cast a void * makes no sense References: <51486eb6860d1680c1bce45e310dcd3aae096f43.1251111439.git.quintela@redhat.com> <4A928DF0.9000106@weilnetz.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: Stefan Weil , qemu-devel@nongnu.org Juan Quintela wrote: > I think it should be applied (qemu sense), but you do eepro100 work, and > I don't do/plan to do more eepro100 work. > I agree with Juan. Overall consistency in the code base is extremely important. Stefan, if you disagree with this style, you should submit a cleanup patch that converts every occurrence of this idiom. Regards, Anthony Liguori