From: Aurelien Jarno <aurelien@aurel32.net>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] target-mips: fix conditional moves off fp condition codes
Date: Tue, 25 Aug 2009 18:07:44 +0200 [thread overview]
Message-ID: <4A940C50.9010809@aurel32.net> (raw)
In-Reply-To: <1251213600-30108-1-git-send-email-froydnj@codesourcery.com>
Nathan Froyd a écrit :
> Conditional moves off fp condition codes were using the result of
> get_fp_bit to isolate and test the relevant condition code. However,
> get_fp_bit returns the bit number of the condition code, not a
> bitmask. (Compare the use of get_fp_bit in gen_compute_branch1, for
> instance.)
>
> Fixed by shifting a bitmask into place using the result of get_fp_bit in
> the relevant functions (gen_mov{ci,cf_s,cf_d,cf_ps}).
>
Thanks, applied to both master and stable.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2009-08-25 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-25 15:20 [Qemu-devel] [PATCH] target-mips: fix conditional moves off fp condition codes Nathan Froyd
2009-08-25 16:07 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A940C50.9010809@aurel32.net \
--to=aurelien@aurel32.net \
--cc=froydnj@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).