From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MfyYz-0000El-8e
	for qemu-devel@nongnu.org; Tue, 25 Aug 2009 12:08:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MfyYy-0000EP-Gw
	for qemu-devel@nongnu.org; Tue, 25 Aug 2009 12:08:00 -0400
Received: from [199.232.76.173] (port=32894 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MfyYy-0000EJ-AQ
	for qemu-devel@nongnu.org; Tue, 25 Aug 2009 12:08:00 -0400
Received: from hall.aurel32.net ([88.191.82.174]:58005)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1MfyYx-0001lM-Qc
	for qemu-devel@nongnu.org; Tue, 25 Aug 2009 12:07:59 -0400
Message-ID: <4A940C50.9010809@aurel32.net>
Date: Tue, 25 Aug 2009 18:07:44 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
MIME-Version: 1.0
References: <1251213600-30108-1-git-send-email-froydnj@codesourcery.com>
In-Reply-To: <1251213600-30108-1-git-send-email-froydnj@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Subject: [Qemu-devel] Re: [PATCH] target-mips: fix conditional moves off fp
	condition codes
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: qemu-devel@nongnu.org

Nathan Froyd a écrit :
> Conditional moves off fp condition codes were using the result of
> get_fp_bit to isolate and test the relevant condition code.  However,
> get_fp_bit returns the bit number of the condition code, not a
> bitmask.  (Compare the use of get_fp_bit in gen_compute_branch1, for
> instance.)
> 
> Fixed by shifting a bitmask into place using the result of get_fp_bit in
> the relevant functions (gen_mov{ci,cf_s,cf_d,cf_ps}).
> 

Thanks, applied to both master and stable.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net