From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MfzaX-00071t-UZ
	for qemu-devel@nongnu.org; Tue, 25 Aug 2009 13:13:41 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MfzaT-0006y8-56
	for qemu-devel@nongnu.org; Tue, 25 Aug 2009 13:13:41 -0400
Received: from [199.232.76.173] (port=44754 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MfzaS-0006y4-TG
	for qemu-devel@nongnu.org; Tue, 25 Aug 2009 13:13:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38306)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1MfzaS-000637-DF
	for qemu-devel@nongnu.org; Tue, 25 Aug 2009 13:13:36 -0400
Message-ID: <4A941BBC.4020504@redhat.com>
Date: Tue, 25 Aug 2009 20:13:32 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/1] Make the e1000 the default
	network	adapter for the pc target.
References: <1250267001-4431-1-git-send-email-aliguori@us.ibm.com>
	<4A93C0C4.7060409@redhat.com>
	<20090825132347.GB23700@csclub.uwaterloo.ca>
	<4A940A40.30608@redhat.com>
	<20090825163028.GD23700@csclub.uwaterloo.ca>
	<4A9413B5.5030108@us.ibm.com> <4A9417D2.1040002@redhat.com>
	<20090825171107.GE23700@csclub.uwaterloo.ca>
In-Reply-To: <20090825171107.GE23700@csclub.uwaterloo.ca>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On 08/25/2009 08:11 PM, Lennart Sorensen wrote:
> On Tue, Aug 25, 2009 at 07:56:50PM +0300, Avi Kivity wrote:
>    
>> Our users will hate us if we do this.  We should look at XP's actual
>> market share, not formal statements from Microsoft.  If market share
>> starts dropping, we can scale back support in qemu.
>>
>> Providing less than optimal performance is a lot better than starting up
>> with no networking.  In any case optimal performance requires a
>> non-default selection (virtio).
>>      
> Well if e1000 gives 95% of the virtio performance, and 8139 gives 50%,
> then I know which I will be using.  Personally I don't care which one
> is default, since I will use e1000 with bridging anyhow.
>    

if (0) is usually optimized away by the compiler.

The default only matters to unmanaged systems.  I think we should aim 
first for working, and later for performance.

-- 
error compiling committee.c: too many arguments to function