From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MgDwB-0004qP-KC for qemu-devel@nongnu.org; Wed, 26 Aug 2009 04:32:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MgDw5-0004o3-BL for qemu-devel@nongnu.org; Wed, 26 Aug 2009 04:32:58 -0400 Received: from [199.232.76.173] (port=37841 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MgDw5-0004nz-72 for qemu-devel@nongnu.org; Wed, 26 Aug 2009 04:32:53 -0400 Received: from mx20.gnu.org ([199.232.41.8]:9541) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MgDw4-000766-PO for qemu-devel@nongnu.org; Wed, 26 Aug 2009 04:32:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MgDw2-00082W-AO for qemu-devel@nongnu.org; Wed, 26 Aug 2009 04:32:51 -0400 Message-ID: <4A94F32D.9050509@redhat.com> Date: Wed, 26 Aug 2009 11:32:45 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/1] Make the e1000 the default network adapter for the pc target. References: <1250267001-4431-1-git-send-email-aliguori@us.ibm.com> <4A93C0C4.7060409@redhat.com> <20090825132347.GB23700@csclub.uwaterloo.ca> <4A940A40.30608@redhat.com> <20090825163028.GD23700@csclub.uwaterloo.ca> <4A9413B5.5030108@us.ibm.com> <4A9417D2.1040002@redhat.com> <20090825171107.GE23700@csclub.uwaterloo.ca> <4A941BBC.4020504@redhat.com> <4A942B1D.1040801@us.ibm.com> In-Reply-To: <4A942B1D.1040801@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Lennart Sorensen On 08/25/2009 09:19 PM, Anthony Liguori wrote: > Avi Kivity wrote: >> if (0) is usually optimized away by the compiler. >> >> The default only matters to unmanaged systems. I think we should aim >> first for working, and later for performance. > > An "unmanaged system" includes a standard distribution where the user > is using virt-manager. From the name, I would have thought that virt-manager is a managed system. > That's what led me down this road in the first place. > I don't follow the logic at all. If qemu is started with model= (which I'd guess a managed system will do), it doesn't matter what the default is. If qemu is not started with model= (which I'd expect from command line), then we should make every effort to bring up a working guest. Have we run out of unintended regressions that we've started to add intended ones? -- error compiling committee.c: too many arguments to function