From: Anthony Liguori <anthony@codemonkey.ws>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 01/11] ide: add IDEBus struct, cleanups
Date: Thu, 27 Aug 2009 18:39:10 -0500 [thread overview]
Message-ID: <4A97191E.7080405@codemonkey.ws> (raw)
In-Reply-To: <1251287619-20022-2-git-send-email-kraxel@redhat.com>
Gerd Hoffmann wrote:
> The current IDE code uses an array of two IDEState structs to maintain
> the IDE bus. This patch adds a IDEBus to be used instead and does a
> bunch of cleanups:
>
> * move ide bus state from IDEState to IDEBus.
> * drop a bunch of ugly pointer arithmetics to figure the active
> interface, explicitly save the interface number instead.
> * add helper functions to save/restore idebus state.
>
> It also fixes a save/restore bug: loadvm allways stores the command in
> the master's IDEState, even when it was saved from the slave.
>
Can you prepare a patch for stable that just fixes this bug? This
sounds like something we want there.
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-08-27 23:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-26 11:53 [Qemu-devel] [PATCH 00/11] ide: split + cleanup patches Gerd Hoffmann
2009-08-26 11:53 ` [Qemu-devel] [PATCH 01/11] ide: add IDEBus struct, cleanups Gerd Hoffmann
2009-08-27 23:39 ` Anthony Liguori [this message]
2009-08-26 11:53 ` [Qemu-devel] [PATCH 02/11] ide: split away ide-internal.h Gerd Hoffmann
2009-08-26 11:53 ` [Qemu-devel] [PATCH 03/11] ide: split away ide-isa.c Gerd Hoffmann
2009-08-26 11:53 ` [Qemu-devel] [PATCH 04/11] ide: split away ide-pci.c Gerd Hoffmann
2009-08-26 11:53 ` [Qemu-devel] [PATCH 05/11] ide: split away ide-macio.c Gerd Hoffmann
2009-08-26 11:53 ` [Qemu-devel] [PATCH 06/11] ide: split away ide-mmio.c Gerd Hoffmann
2009-08-26 11:53 ` [Qemu-devel] [PATCH 07/11] ide: split away ide-microdrive.c Gerd Hoffmann
2009-08-26 11:53 ` [Qemu-devel] [PATCH 08/11] ide: add save/restore support for isa Gerd Hoffmann
2009-08-26 11:53 ` [Qemu-devel] [PATCH 09/11] ide: add save/restore support for mmio Gerd Hoffmann
2009-08-26 11:53 ` [Qemu-devel] [PATCH 10/11] ide: move code to hw/ide/ Gerd Hoffmann
2009-08-26 11:53 ` [Qemu-devel] [PATCH 11/11] ide: pass down DriveInfo instead of BlockDriverState Gerd Hoffmann
2009-08-28 0:48 ` [Qemu-devel] [PATCH 00/11] ide: split + cleanup patches Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A97191E.7080405@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).