From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MgorF-0001FM-OP
	for qemu-devel@nongnu.org; Thu, 27 Aug 2009 19:58:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MgorB-0001Ed-0n
	for qemu-devel@nongnu.org; Thu, 27 Aug 2009 19:58:21 -0400
Received: from [199.232.76.173] (port=46819 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MgorA-0001Ea-QW
	for qemu-devel@nongnu.org; Thu, 27 Aug 2009 19:58:16 -0400
Received: from mail-qy0-f188.google.com ([209.85.221.188]:54736)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MgoYl-0001DB-5m
	for qemu-devel@nongnu.org; Thu, 27 Aug 2009 19:39:15 -0400
Received: by qyk26 with SMTP id 26so1020091qyk.29
	for <qemu-devel@nongnu.org>; Thu, 27 Aug 2009 16:39:13 -0700 (PDT)
Message-ID: <4A97191E.7080405@codemonkey.ws>
Date: Thu, 27 Aug 2009 18:39:10 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 01/11] ide: add IDEBus struct, cleanups
References: <1251287619-20022-1-git-send-email-kraxel@redhat.com>
	<1251287619-20022-2-git-send-email-kraxel@redhat.com>
In-Reply-To: <1251287619-20022-2-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann wrote:
> The current IDE code uses an array of two IDEState structs to maintain
> the IDE bus.  This patch adds a IDEBus to be used instead and does a
> bunch of cleanups:
>
>  * move ide bus state from IDEState to IDEBus.
>  * drop a bunch of ugly pointer arithmetics to figure the active
>    interface, explicitly save the interface number instead.
>  * add helper functions to save/restore idebus state.
>
> It also fixes a save/restore bug: loadvm allways stores the command in
> the master's IDEState, even when it was saved from the slave.
>   

Can you prepare a patch for stable that just fixes this bug?  This 
sounds like something we want there.

> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Regards,

Anthony Liguori