From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mh54K-0006L7-Tg
	for qemu-devel@nongnu.org; Fri, 28 Aug 2009 13:16:56 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mh54G-0006Dz-7a
	for qemu-devel@nongnu.org; Fri, 28 Aug 2009 13:16:56 -0400
Received: from [199.232.76.173] (port=55478 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mh54F-0006DP-Vg
	for qemu-devel@nongnu.org; Fri, 28 Aug 2009 13:16:52 -0400
Received: from mail-px0-f192.google.com ([209.85.216.192]:46420)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Mh54F-00085W-81
	for qemu-devel@nongnu.org; Fri, 28 Aug 2009 13:16:51 -0400
Received: by pxi30 with SMTP id 30so1875402pxi.18
	for <qemu-devel@nongnu.org>; Fri, 28 Aug 2009 10:16:50 -0700 (PDT)
Message-ID: <4A9810F7.1020401@codemonkey.ws>
Date: Fri, 28 Aug 2009 12:16:39 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [HACK] make vmmouse work with KVM
References: <20090817144754.GA31553@1und1.de>
	<4A89730F.7090206@codemonkey.ws>	<20090817154557.GB365@1und1.de>
	<4A8988DB.3040108@gnu.org>	<20090817170017.GB1835@1und1.de>
	<4A899081.9010508@gnu.org>	<20090817173232.GA1961@1und1.de>
	<20090828155338.GA25860@1und1.de>
In-Reply-To: <20090828155338.GA25860@1und1.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Reimar Döffinger wrote:
> On Mon, Aug 17, 2009 at 07:32:32PM +0200, Reimar Döffinger wrote:
>   
>> On Mon, Aug 17, 2009 at 07:16:49PM +0200, Paolo Bonzini wrote:
>>     
>>> On 08/17/2009 07:00 PM, Reimar Döffinger wrote:
>>>       
>>>> On Mon, Aug 17, 2009 at 06:44:11PM +0200, Paolo Bonzini wrote:
>>>>         
>>>>> On 08/17/2009 05:45 PM, Reimar Döffinger wrote:
>>>>>           
>>>>>> +    cpu_synchronize_state(env, 0);
>>>>>>        env->regs[R_EAX] = vmport_ioport_read(opaque, addr);
>>>>>> +    cpu_synchronize_state(env, 1);
>>>>>>             
>>>>> This is not needed because the sync is done in vmport_ioport_read, isn't it?
>>>>>           
>>>> Well... The cpu_synchronize_state could be dropped you are right, but
>>>> here we write R_EAX so the cpu_synchronize_state(env, 1) is necessary.
>>>> It might be slightly cleaner to rename the vmport_ioport_read (any name
>>>> suggestions?) and add a wrapper for register_ioport_read that does the
>>>> cpu_synchronize_state (so it looks similar to vmport_ioport_write).
>>>>         
>>> Yes, that would look best and wouldn't have fooled me. Could 
>>> vmport_ioport_trigger be a decent name?
>>>       
>> Since what that function actually does is execute a specific command it
>> gets from ecx I went with vmport_ioport_command, but I'll happily leave
>> the naming to whoever applies it :-)
>>     
>
> Simpler version due to new cpu_synchronize_state behaviour.
>   

Please top post patches.

Regards,

Anthony Liguori