From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mh6US-0004zI-VF
	for qemu-devel@nongnu.org; Fri, 28 Aug 2009 14:48:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mh6UO-0004s4-8j
	for qemu-devel@nongnu.org; Fri, 28 Aug 2009 14:48:00 -0400
Received: from [199.232.76.173] (port=59533 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mh6UN-0004ra-R3
	for qemu-devel@nongnu.org; Fri, 28 Aug 2009 14:47:55 -0400
Received: from moutng.kundenserver.de ([212.227.126.186]:50106)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1Mh6UN-0005mY-66
	for qemu-devel@nongnu.org; Fri, 28 Aug 2009 14:47:55 -0400
Received: from localhost ([127.0.0.1] ident=stefan)
	by flocke.weilnetz.de with esmtp (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1Mh6UK-00043j-3b
	for qemu-devel@nongnu.org; Fri, 28 Aug 2009 20:47:52 +0200
Message-ID: <4A982658.30606@mail.berlios.de>
Date: Fri, 28 Aug 2009 20:47:52 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <4A97C3B4.8030006@mail.berlios.de>
	<1251460100-11333-1-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1251460100-11333-1-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] mips malta: Fix fdc regression
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: QEMU Developers <qemu-devel@nongnu.org>

Stefan Weil schrieb:
> 8baf73adf664e79eae201c3f618078a220a661d9 (qdev/isa: convert fdc)
> breaks MIPS Malta:
>
> Tried to create isa device isa-fdc with no isa bus present
>
> Fix this by creating an isa bus for piix4.
>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  hw/piix_pci.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index c9fef92..91fd038 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -365,6 +365,7 @@ static int piix4_initfn(PCIDevice *d)
>  {
>      uint8_t *pci_conf;
>  
> +    isa_bus_new(&d->qdev);
>      register_savevm("PIIX4", 0, 2, piix_save, piix_load, d);
>  
>      pci_conf = d->config;
>   

This patch no longer is sufficient with latest QEMU
because ISA irqs also have to be defined (otherwise
the MIPS Malta emulation gets a runtime crash).

Please don't use it.

Use the new patch (mips malta: Fix fdc regression and use qdev for i8042
setup).

Regards
Stefan