[Qemu-devel] [PATCH] call make with quite-command

[Qemu-devel] [PATCH] call make with quite-command

[Juan Quintela]

On top of new config series. Remove the make directory printing.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 Makefile        |    3 ++-
 Makefile.target |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 1befee0..236fb03 100644
--- a/Makefile
+++ b/Makefile
@@ -28,6 +28,7 @@ DOCS=
 endif

 SUBDIR_DEVICES_MAK=$(patsubst %, %/config-devices.mak, $(TARGET_DIRS))
+SUBDIR_MAKEFLAGS=$(if $(V),,--no-print-directory)

 config-all-devices.mak: $(SUBDIR_DEVICES_MAK)
 	$(call quiet-command,grep "=y$$" $(SUBDIR_DEVICES_MAK) | sort -u > $@,"  GEN  $@")
@@ -35,7 +36,7 @@ config-all-devices.mak: $(SUBDIR_DEVICES_MAK)
 include config-all-devices.mak

 build-all: config-host.h
-	$(MAKE) $(TOOLS) $(DOCS) recurse-all
+	$(call quiet-command, $(MAKE) $(SUBDIR_MAKEFLAGS) $(TOOLS) $(DOCS) recurse-all,)

 config-host.h: config-host.h-timestamp
 config-host.h-timestamp: config-host.mak
diff --git a/Makefile.target b/Makefile.target
index d244f7a..f1887e2 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -31,7 +31,7 @@ config-target.h: config-target.h-timestamp
 config-target.h-timestamp: config-target.mak

 all: config-target.h
-	$(MAKE) $(PROGS)
+	$(call quiet-command, $(MAKE) $(PROGS),)

 # Dummy command so that make thinks it has done something
 	@true
-- 
1.6.2.5

Re: [Qemu-devel] [PATCH] call make with quite-command

[Johannes Schindelin]

Hi,

"quite command"?

On Sat, 29 Aug 2009, Juan Quintela wrote:

> +	$(call quiet-command, $(MAKE) $(SUBDIR_MAKEFLAGS) $(TOOLS) $(DOCS) recurse-all,)

Ah.  "quiet" command.

How dependent is that on GNU make?

Ciao,
Dscho

[Qemu-devel] Re: [PATCH] call make with quite-command

[Juan Quintela]

Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> "quite command"?
>
> On Sat, 29 Aug 2009, Juan Quintela wrote:
>
>> +	$(call quiet-command, $(MAKE) $(SUBDIR_MAKEFLAGS) $(TOOLS) $(DOCS) recurse-all,)
>
> Ah.  "quiet" command.
>
> How dependent is that on GNU make?


I hope nothing.

quiet-command = $(if $(V),$1,$(if $(2),@echo $2 && $1, @$1))

that is its definition.  I hope/guess that $(if ...) is normal make.

Humm, looking at POSIX, it appears that they don't have functions at
all, but they don't have % rules either :p

Later, Juan.

> Ciao,
> Dscho

[Qemu-devel] Re: [PATCH] call make with quite-command

[Paolo Bonzini]

On 08/30/2009 10:05 PM, Juan Quintela wrote:
> Johannes Schindelin<Johannes.Schindelin@gmx.de>  wrote:
>> Hi,
>>
>> "quite command"?
>>
>> On Sat, 29 Aug 2009, Juan Quintela wrote:
>>
>>> +	$(call quiet-command, $(MAKE) $(SUBDIR_MAKEFLAGS) $(TOOLS) $(DOCS) recurse-all,)
>>
>> Ah.  "quiet" command.
>>
>> How dependent is that on GNU make?
>
> I hope nothing.

Actually, very. :-)  But anyway qemu does not compile without GNU make.

Paolo