qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <bonzini@gnu.org>
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 1/2] Remove CFLAGS parameter in cc-option
Date: Mon, 31 Aug 2009 08:54:14 +0200	[thread overview]
Message-ID: <4A9B7396.9090208@gnu.org> (raw)
In-Reply-To: <524d68ff85692c828b714ecf4dfdca248bb52f38.1251672463.git.quintela@redhat.com>

On 08/31/2009 12:48 AM, Juan Quintela wrote:
> With cc-option we are testing if gcc just accept a particular option, we don't need CFLAGS at all.

ACK, however these should IMO be moved to configure.  This:

> CFLAGS += $(call cc-option, -fno-stack-protector,"")

is likely responsible of at least 20% system time to the compilation 
(because one normal compilation costs three forks for gcc+cc1+as, and 
cc-option costs two more for gcc+cc1).

Paolo

  reply	other threads:[~2009-08-31  6:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1251672463.git.quintela@redhat.com>
2009-08-30 22:48 ` [Qemu-devel] [PATCH 1/2] Remove CFLAGS parameter in cc-option Juan Quintela
2009-08-31  6:54   ` Paolo Bonzini [this message]
2009-08-30 22:48 ` [Qemu-devel] [PATCH 2/2] otionrom: Use local CFLAGS no global one Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A9B7396.9090208@gnu.org \
    --to=bonzini@gnu.org \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).