From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mi0mX-0002PQ-2a
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 02:54:25 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mi0mS-0002Mq-4Z
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 02:54:24 -0400
Received: from [199.232.76.173] (port=47412 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mi0mR-0002Mf-U1
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 02:54:19 -0400
Received: from mail-ew0-f223.google.com ([209.85.219.223]:60956)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Mi0mR-0007rr-6E
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 02:54:19 -0400
Received: by ewy23 with SMTP id 23so4186055ewy.8
	for <qemu-devel@nongnu.org>; Sun, 30 Aug 2009 23:54:17 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4A9B7396.9090208@gnu.org>
Date: Mon, 31 Aug 2009 08:54:14 +0200
From: Paolo Bonzini <bonzini@gnu.org>
MIME-Version: 1.0
References: <cover.1251672463.git.quintela@redhat.com>
	<524d68ff85692c828b714ecf4dfdca248bb52f38.1251672463.git.quintela@redhat.com>
In-Reply-To: <524d68ff85692c828b714ecf4dfdca248bb52f38.1251672463.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/2] Remove CFLAGS parameter in cc-option
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On 08/31/2009 12:48 AM, Juan Quintela wrote:
> With cc-option we are testing if gcc just accept a particular option, we don't need CFLAGS at all.

ACK, however these should IMO be moved to configure.  This:

> CFLAGS += $(call cc-option, -fno-stack-protector,"")

is likely responsible of at least 20% system time to the compilation 
(because one normal compilation costs three forks for gcc+cc1+as, and 
cc-option costs two more for gcc+cc1).

Paolo