Re: [Qemu-devel] [PATCH 26/29] Introduce QInt unit-tests

[Kevin Wolf <kwolf@redhat.com>]

Luiz Capitulino schrieb:
> This suite contains tests to assure that QInt API works as expected.
> 
> To execute it you should have check installed and build QEMU with
> check support enabled (--enable-check-utests) and then run:
> 
> $ ./check-qint
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  Makefile     |    2 +
>  check-qint.c |  110 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  configure    |    2 +-
>  3 files changed, 113 insertions(+), 1 deletions(-)
>  create mode 100644 check-qint.c

Shouldn't these tests better go in some subdirectory like tests/qobjects?

> diff --git a/Makefile b/Makefile
> index 983fe39..d08df6c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -181,6 +181,8 @@ qemu-io$(EXESUF):  qemu-io.o qemu-tool.o cmd.o $(block-obj-y)
>  qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx
>  	$(call quiet-command,sh $(SRC_PATH)/hxtool -h < $< > $@,"  GEN   $@")
>  
> +check-qint: check-qint.o qint.o qemu-malloc.o
> +
>  clean:
>  # avoid old build problems by removing potentially incorrect old files
>  	rm -f config.mak config.h op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h
> diff --git a/check-qint.c b/check-qint.c
> new file mode 100644
> index 0000000..ae5d22f
> --- /dev/null
> +++ b/check-qint.c
> @@ -0,0 +1,110 @@
> +/*
> + * QInt unit-tests.
> + *
> + * Copyright (C) 2009 Red Hat Inc.
> + *
> + * Authors:
> + *  Luiz Capitulino <lcapitulino@redhat.com>
> + */

No license?

Kevin