From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mi1lF-00032X-4t for qemu-devel@nongnu.org; Mon, 31 Aug 2009 03:57:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mi1l9-0002st-Nd for qemu-devel@nongnu.org; Mon, 31 Aug 2009 03:57:07 -0400 Received: from [199.232.76.173] (port=34936 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mi1l9-0002sn-Hz for qemu-devel@nongnu.org; Mon, 31 Aug 2009 03:57:03 -0400 Received: from mx20.gnu.org ([199.232.41.8]:1781) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mi1l8-0007hY-VJ for qemu-devel@nongnu.org; Mon, 31 Aug 2009 03:57:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mi1l7-0006wF-Cl for qemu-devel@nongnu.org; Mon, 31 Aug 2009 03:57:01 -0400 Message-ID: <4A9B8209.1010900@redhat.com> Date: Mon, 31 Aug 2009 09:55:53 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 26/29] Introduce QInt unit-tests References: <1251484052-3939-1-git-send-email-lcapitulino@redhat.com> <1251484052-3939-27-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1251484052-3939-27-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, avi@redhat.com Luiz Capitulino schrieb: > This suite contains tests to assure that QInt API works as expected. > > To execute it you should have check installed and build QEMU with > check support enabled (--enable-check-utests) and then run: > > $ ./check-qint > > Signed-off-by: Luiz Capitulino > --- > Makefile | 2 + > check-qint.c | 110 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > configure | 2 +- > 3 files changed, 113 insertions(+), 1 deletions(-) > create mode 100644 check-qint.c Shouldn't these tests better go in some subdirectory like tests/qobjects? > diff --git a/Makefile b/Makefile > index 983fe39..d08df6c 100644 > --- a/Makefile > +++ b/Makefile > @@ -181,6 +181,8 @@ qemu-io$(EXESUF): qemu-io.o qemu-tool.o cmd.o $(block-obj-y) > qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx > $(call quiet-command,sh $(SRC_PATH)/hxtool -h < $< > $@," GEN $@") > > +check-qint: check-qint.o qint.o qemu-malloc.o > + > clean: > # avoid old build problems by removing potentially incorrect old files > rm -f config.mak config.h op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h > diff --git a/check-qint.c b/check-qint.c > new file mode 100644 > index 0000000..ae5d22f > --- /dev/null > +++ b/check-qint.c > @@ -0,0 +1,110 @@ > +/* > + * QInt unit-tests. > + * > + * Copyright (C) 2009 Red Hat Inc. > + * > + * Authors: > + * Luiz Capitulino > + */ No license? Kevin