qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH, RFC 0/5] Improve device info handling
Date: Mon, 31 Aug 2009 10:12:21 +0200	[thread overview]
Message-ID: <4A9B85E5.8040902@redhat.com> (raw)
In-Reply-To: <f43fc5580908290706j6f38433akbb1d0dda0b5cf456@mail.gmail.com>

   Hi,

> Add info command registration to the API and make some devices use it.

Jumping in here with a more general comment ...

I think right now we have _way_ to much register_something functions.
IMHO qdev allows us to kill off most of them.  We can stick function 
pointers (also VMstate pointers) into DeviceInfo instead of registering 
callbacks.

Short-term (while we are in the "convert-drivers-to-qdev" phase) that 
will just move the register calls from the driver code to generic qdev code.

Long-term we hopefully can kill the register calls altogether and walk 
the qdev device tree instead.

> User visible monitor commands change: 'info' is replaced by 'dev_info'
> and also the parameter name may change, for example 'pic' becomes
> 'i8259.state'.

Hmm, i8259 isn't converted to qdev yet, so the route outlined above 
above will not work (yet) for this device ...

cheers,
   Gerd

  reply	other threads:[~2009-08-31  8:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-29 14:06 [Qemu-devel] [PATCH, RFC 0/5] Improve device info handling Blue Swirl
2009-08-31  8:12 ` Gerd Hoffmann [this message]
2009-08-31 15:23   ` Blue Swirl
2009-09-01  7:54     ` Gerd Hoffmann
2009-09-01 16:21       ` Blue Swirl
2009-09-02  6:35         ` Gerd Hoffmann
2009-09-02 14:41           ` Blue Swirl
2009-09-02 16:42             ` Gerd Hoffmann
2009-09-02 17:53               ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A9B85E5.8040902@redhat.com \
    --to=kraxel@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).