From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mi20A-0002yY-CW
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 04:12:34 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mi205-0002yM-Jx
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 04:12:33 -0400
Received: from [199.232.76.173] (port=56617 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mi205-0002yJ-Fc
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 04:12:29 -0400
Received: from mx20.gnu.org ([199.232.41.8]:2991)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <kraxel@redhat.com>) id 1Mi205-0001So-13
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 04:12:29 -0400
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Mi204-00085r-5Z
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 04:12:28 -0400
Message-ID: <4A9B85E5.8040902@redhat.com>
Date: Mon, 31 Aug 2009 10:12:21 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH, RFC 0/5] Improve device info handling
References: <f43fc5580908290706j6f38433akbb1d0dda0b5cf456@mail.gmail.com>
In-Reply-To: <f43fc5580908290706j6f38433akbb1d0dda0b5cf456@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

   Hi,

> Add info command registration to the API and make some devices use it.

Jumping in here with a more general comment ...

I think right now we have _way_ to much register_something functions.
IMHO qdev allows us to kill off most of them.  We can stick function 
pointers (also VMstate pointers) into DeviceInfo instead of registering 
callbacks.

Short-term (while we are in the "convert-drivers-to-qdev" phase) that 
will just move the register calls from the driver code to generic qdev code.

Long-term we hopefully can kill the register calls altogether and walk 
the qdev device tree instead.

> User visible monitor commands change: 'info' is replaced by 'dev_info'
> and also the parameter name may change, for example 'pic' becomes
> 'i8259.state'.

Hmm, i8259 isn't converted to qdev yet, so the route outlined above 
above will not work (yet) for this device ...

cheers,
   Gerd