From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MiHeu-0005YW-30
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 20:55:40 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MiHep-0005Wn-7x
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 20:55:39 -0400
Received: from [199.232.76.173] (port=42167 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MiHep-0005Wi-5h
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 20:55:35 -0400
Received: from mail-ew0-f222.google.com ([209.85.219.222]:43573)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paolo.bonzini@gmail.com>) id 1MiHeo-0004zL-O0
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 20:55:34 -0400
Received: by ewy22 with SMTP id 22so4614856ewy.28
	for <qemu-devel@nongnu.org>; Mon, 31 Aug 2009 17:55:33 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4A9C7100.1020501@gnu.org>
Date: Tue, 01 Sep 2009 02:55:28 +0200
From: Paolo Bonzini <bonzini@gnu.org>
MIME-Version: 1.0
References: <1247781328-17249-1-git-send-email-glommer@redhat.com>	<4A96BF30.7090200@siemens.com>	<20090828011856.GE5746@mothafucka.localdomain>	<4A973530.4040002@us.ibm.com>
	<20090829012227.GH8036@shareable.org>
	<20090831113518.GD30340@mothafucka.localdomain>
In-Reply-To: <20090831113518.GD30340@mothafucka.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v3] introduce on_vcpu
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, avi@redhat.com

On 08/31/2009 01:35 PM, Glauber Costa wrote:
> On Sat, Aug 29, 2009 at 02:22:27AM +0100, Jamie Lokier wrote:
>> Anthony Liguori wrote:
>>> Glauber Costa wrote:
>>> Since we already keep the tid in the vcpu structure, it seems to make
>>> more sense to ask "am I this vcpu thread" by doing gettid() == env->tid
>>> than by maintaining a new global tls variable.
>>
>> Note that a tls variable will be much faster than gettid().  Don't
>> know if you're talking about a hot path.
> just to be sure, TLS is not supported on all our linux target hosts, right?

I think it is.

~/devel/gcc/gcc pbonzini$ grep -l SYMBOL_REF_TLS_MODEL config/*/*.c
config/alpha/alpha.c
config/arm/arm.c
config/frv/frv.c
config/i386/i386.c
config/ia64/ia64.c
config/m68k/m68k.c
config/mips/mips.c
config/pa/pa.c
config/rs6000/rs6000.c
config/s390/s390.c
config/sh/sh.c
config/sparc/sparc.c
config/xtensa/xtensa.c

Paolo