From: Gerd Hoffmann <kraxel@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] savevm: Convert savevm handlers list to TAILQ
Date: Tue, 01 Sep 2009 10:33:24 +0200 [thread overview]
Message-ID: <4A9CDC54.6000003@redhat.com> (raw)
In-Reply-To: <2677d960a55ec82b47b571062c5d41b1b71e4ed1.1251491268.git.quintela@redhat.com>
Hi,
> int vmstate_register(int instance_id, const VMStateDescription *vmsd,
> void *opaque)
> void vmstate_unregister(const char *idstr, void *opaque)
> {
vmstate_unregister() should accept the same parameters passed to
vmstate_register(). idstr does not fit here. Should probably be either
vmsd + opaque or just opaque.
cheers,
Gerd
next prev parent reply other threads:[~2009-09-01 8:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-28 20:31 [Qemu-devel] [PATCH 0/3] Bring savevm.c to the wonderful world of sys-queue.h Juan Quintela
2009-08-28 20:31 ` [Qemu-devel] [PATCH 1/3] savevm: Convert savevm handlers list to TAILQ Juan Quintela
2009-09-01 8:33 ` Gerd Hoffmann [this message]
2009-08-28 20:31 ` [Qemu-devel] [PATCH 2/3] Add LIST_FOREACH_SAFE() definition Juan Quintela
2009-08-28 20:31 ` [Qemu-devel] [PATCH 3/3] savevm: Convert loadvm handlers list to LIST Juan Quintela
2009-08-31 19:00 ` Luiz Capitulino
2009-08-31 22:08 ` [Qemu-devel] " Juan Quintela
2009-08-31 22:27 ` Luiz Capitulino
2009-09-01 0:25 ` Juan Quintela
-- strict thread matches above, loose matches on Subject: below --
2009-09-01 0:12 [Qemu-devel] [PATCH 0/3] Bring savevm.c to the wonderful world of sys-queue.h Juan Quintela
2009-09-01 0:12 ` [Qemu-devel] [PATCH 1/3] savevm: Convert savevm handlers list to TAILQ Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9CDC54.6000003@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).