From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MiOo2-0005uf-6x
	for qemu-devel@nongnu.org; Tue, 01 Sep 2009 04:33:34 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MiOnx-0005sw-Ii
	for qemu-devel@nongnu.org; Tue, 01 Sep 2009 04:33:33 -0400
Received: from [199.232.76.173] (port=54281 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MiOnx-0005st-Fo
	for qemu-devel@nongnu.org; Tue, 01 Sep 2009 04:33:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:4569)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MiOnw-0007xa-TP
	for qemu-devel@nongnu.org; Tue, 01 Sep 2009 04:33:29 -0400
Message-ID: <4A9CDC54.6000003@redhat.com>
Date: Tue, 01 Sep 2009 10:33:24 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/3] savevm: Convert savevm handlers list
	to	TAILQ
References: <cover.1251491268.git.quintela@redhat.com>
	<2677d960a55ec82b47b571062c5d41b1b71e4ed1.1251491268.git.quintela@redhat.com>
In-Reply-To: <2677d960a55ec82b47b571062c5d41b1b71e4ed1.1251491268.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

   Hi,

>   int vmstate_register(int instance_id, const VMStateDescription *vmsd,
>                        void *opaque)

>   void vmstate_unregister(const char *idstr,  void *opaque)
>   {

vmstate_unregister() should accept the same parameters passed to 
vmstate_register().  idstr does not fit here.  Should probably be either 
vmsd + opaque or just opaque.

cheers,
   Gerd