qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qcow2: Order concurrent AIO requests on the	same unallocated cluster
Date: Tue, 01 Sep 2009 13:43:58 +0200	[thread overview]
Message-ID: <4A9D08FE.4070008@redhat.com> (raw)
In-Reply-To: <4A9D047E.1040208@redhat.com>

Avi Kivity schrieb:
> On 09/01/2009 01:50 PM, Kevin Wolf wrote:
>>   You
>> are worried about image fragmentation? I think we could do something
>> about it with a cleverer cluster allocation.
>>    
> 
> Not only image fragmentation - the odd requests will require RMW.

How that?

The case you're thinking of is that the first and third request are
already completed and then the second one starts, right? Assuming that
request 2 involves some sectors in the last cluster of 1 and the first
one of 3.

Then request 2 is written in three phases: The first one overwrites the
last sectors of requests 1 (cluster already allocated => no RMW). The
second one writes to unallocated, cluster-aligned space (writing
complete clusters => no RMW). The third one overwrites the first sectors
of request 3 (cluster already allocated => no RMW).

>>> Do you have performance numbers?
>>>      
>> No really detailed numbers. Installation time for RHEL on qcow2/virtio
>> went down from 34 min to 19 min, though.
>>    
> 
> That's very impressive.  cache=none or cache=wt?

This was with cache=none as are most of my ad-hoc tests (with cache=none
being the default for RHEL).

Kevin

  parent reply	other threads:[~2009-09-01 11:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-31 14:48 [Qemu-devel] [PATCH] qcow2: Order concurrent AIO requests on the same unallocated cluster Kevin Wolf
2009-09-01 10:19 ` Avi Kivity
2009-09-01 10:50   ` Kevin Wolf
2009-09-01 11:24     ` Avi Kivity
2009-09-01 11:26       ` Gleb Natapov
2009-09-01 12:29         ` Kevin Wolf
2009-09-01 12:53           ` Avi Kivity
2009-09-01 13:15             ` Kevin Wolf
2009-09-01 11:43       ` Kevin Wolf [this message]
2009-09-01 11:55         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A9D08FE.4070008@redhat.com \
    --to=kwolf@redhat.com \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).