From: Gerd Hoffmann <kraxel@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] qdev: integrate reset
Date: Wed, 02 Sep 2009 08:43:38 +0200 [thread overview]
Message-ID: <4A9E141A.7000605@redhat.com> (raw)
In-Reply-To: <f43fc5580909010930s56affafdi880667809e097fcf@mail.gmail.com>
On 09/01/09 18:30, Blue Swirl wrote:
> On Tue, Sep 1, 2009 at 10:56 AM, Gerd Hoffmann<kraxel@redhat.com> wrote:
>
>> @@ -110,6 +110,9 @@ struct DeviceInfo {
>> Property *props;
>> int no_user;
>>
>> + /* callbacks */
>> + QEMUResetHandler *reset;
>> +
>
> This would remove the need for registration but I had in my mind a bit
> more complex solution like VMState structures. Even better, VMState
> could be enhanced so that the reset value of the fields could be
> specified (when not zero).
Interesting idea. Could work out pretty nicely. Chances are that the
overlap of the fields which must be initialized on reset and which must
be saved on migration is pretty high. If so the integration into
vmstate would indeed make alot of sense.
cheers,
Gerd
next prev parent reply other threads:[~2009-09-02 6:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 7:56 [Qemu-devel] [PATCH 0/4] integrate more device handling bits with qdev Gerd Hoffmann
2009-09-01 7:56 ` [Qemu-devel] [PATCH 1/4] qdev: integrate reset Gerd Hoffmann
2009-09-01 16:30 ` Blue Swirl
[not found] ` <m33a76mxkc.fsf@neno.mitica>
2009-09-01 16:45 ` [Qemu-devel] " Blue Swirl
2009-09-02 6:43 ` Gerd Hoffmann [this message]
2009-09-01 7:56 ` [Qemu-devel] [PATCH 2/4] qdev: convert rtl8139 to reset Gerd Hoffmann
2009-09-01 7:56 ` [Qemu-devel] [PATCH 3/4] qdev: integrate vmstate Gerd Hoffmann
2009-09-01 7:56 ` [Qemu-devel] [PATCH 4/4] qdev: convert tcx to reset + vmsd Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9E141A.7000605@redhat.com \
--to=kraxel@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).