From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MjaOi-0002U2-RZ
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 11:08:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MjaOd-0002Pp-Dm
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 11:08:20 -0400
Received: from [199.232.76.173] (port=45975 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MjaOd-0002Pe-83
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 11:08:15 -0400
Received: from an-out-0708.google.com ([209.85.132.249]:62506)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MjaOc-0002oI-Nu
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 11:08:15 -0400
Received: by an-out-0708.google.com with SMTP id c38so350404ana.37
	for <qemu-devel@nongnu.org>; Fri, 04 Sep 2009 08:08:12 -0700 (PDT)
Message-ID: <4AA12D59.6040208@codemonkey.ws>
Date: Fri, 04 Sep 2009 10:08:09 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/5] qdev: device capabilities
References: <1251714459-2467-1-git-send-email-kraxel@redhat.com>
In-Reply-To: <1251714459-2467-1-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann wrote:
>   Hi,
>
> This patch series adds device capabilities to qdev devices.
>
> First patch adds the infrastructure, next patches add the capabilities.
> New member of this patch series is #5 which adds a watchdog capability
> and uses it to kill the superfluous private driver list in watchdog.c.
>
> Individual patches have more detailed descriptions.
>   

I still don't understand why this is needed.  It's duplicating data that 
should already be present in the device model.

A device has a capability because it supports a particular interface.  
Doesn't it make more sense to tie that interface to qdev instead of 
having to explicitly state the device has that interface?

Regards,

Anthony Liguori

> cheers,
>   Gerd
>
>
>
>