From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MjaWv-0005re-Qc
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 11:16:49 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MjaWq-0005pf-8j
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 11:16:48 -0400
Received: from [199.232.76.173] (port=56244 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MjaWq-0005pY-3c
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 11:16:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50150)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MjaWp-0004La-QD
	for qemu-devel@nongnu.org; Fri, 04 Sep 2009 11:16:44 -0400
Message-ID: <4AA12F46.6000207@redhat.com>
Date: Fri, 04 Sep 2009 17:16:22 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/5] qdev: device capabilities
References: <1251714459-2467-1-git-send-email-kraxel@redhat.com>
	<4AA12D59.6040208@codemonkey.ws>
In-Reply-To: <4AA12D59.6040208@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On 09/04/09 17:08, Anthony Liguori wrote:
> Gerd Hoffmann wrote:
>> Hi,
>>
>> This patch series adds device capabilities to qdev devices.
>>
>> First patch adds the infrastructure, next patches add the capabilities.
>> New member of this patch series is #5 which adds a watchdog capability
>> and uses it to kill the superfluous private driver list in watchdog.c.
>>
>> Individual patches have more detailed descriptions.
>
> I still don't understand why this is needed. It's duplicating data that
> should already be present in the device model.

Look at patch #5 (watchdogs).  What else do you suggest here?
There is nothing which can be used to identify the device as watchdog.

cheers,
   Gerd