From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MjvUv-0005PL-9z for qemu-devel@nongnu.org; Sat, 05 Sep 2009 09:40:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MjvUp-0005ON-7A for qemu-devel@nongnu.org; Sat, 05 Sep 2009 09:40:07 -0400 Received: from [199.232.76.173] (port=48283 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MjvUp-0005OD-0a for qemu-devel@nongnu.org; Sat, 05 Sep 2009 09:40:03 -0400 Received: from qw-out-1920.google.com ([74.125.92.150]:35074) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MjvUo-0004HI-NE for qemu-devel@nongnu.org; Sat, 05 Sep 2009 09:40:02 -0400 Received: by qw-out-1920.google.com with SMTP id 5so369847qwc.4 for ; Sat, 05 Sep 2009 06:40:01 -0700 (PDT) Message-ID: <4AA26A2D.4010605@codemonkey.ws> Date: Sat, 05 Sep 2009 08:39:57 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/5] qdev: device capabilities References: <1251714459-2467-1-git-send-email-kraxel@redhat.com> <4AA12D59.6040208@codemonkey.ws> <4AA12F46.6000207@redhat.com> In-Reply-To: <4AA12F46.6000207@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Gerd Hoffmann wrote: > Look at patch #5 (watchdogs). What else do you suggest here? > There is nothing which can be used to identify the device as watchdog. That's a problem with the watchdog timers. The WatchdogTimerModel stuff really replicates qdev functionality. Ideally, the watchdog_list would go away and we would just make -watchdog an alias for -device. Instead of having a global watchdog action, we should have a watchdog frontend/backend and allow a user to specify the action for a watchdog backend. This is basically what -watchdog-action does. The current command line options assume one global watchdog. I don't see why we shouldn't support two though. Even if we limited ourselves to one, it should use the same infrastructure as everything else. Regards, Anthony Liguori