From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MkkyB-0004Du-8l
	for qemu-devel@nongnu.org; Mon, 07 Sep 2009 16:37:47 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mkky6-0004DE-KO
	for qemu-devel@nongnu.org; Mon, 07 Sep 2009 16:37:46 -0400
Received: from [199.232.76.173] (port=37664 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mkky6-0004DB-GJ
	for qemu-devel@nongnu.org; Mon, 07 Sep 2009 16:37:42 -0400
Received: from mail-qy0-f172.google.com ([209.85.221.172]:56939)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Mkky6-0001GE-7i
	for qemu-devel@nongnu.org; Mon, 07 Sep 2009 16:37:42 -0400
Received: by qyk2 with SMTP id 2so2185552qyk.21
	for <qemu-devel@nongnu.org>; Mon, 07 Sep 2009 13:37:40 -0700 (PDT)
Message-ID: <4AA56ECD.3040400@codemonkey.ws>
Date: Mon, 07 Sep 2009 15:36:29 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/5] qdev: device capabilities
References: <1251714459-2467-1-git-send-email-kraxel@redhat.com>
	<4AA12D59.6040208@codemonkey.ws> <4AA12F46.6000207@redhat.com>
	<4AA26A2D.4010605@codemonkey.ws> <4AA4E4B9.4020208@redhat.com>
In-Reply-To: <4AA4E4B9.4020208@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann wrote:
> Patch #5 does just that.  Almost.  -watchdog continues to accept 
> watchdog devices only.  And '-watchdog ?' lists watchdog devices only.
>
> watchdog_list is gone, the qdev list is used instead.  To identify the 
> watchdog devices in the qdev device model list the capability bit is 
> used.  The patch description says so, doesn't it?

Instead of checking the capability bit, why not look for a property with 
a type that's unique to the watch dog timer.

Regards,

Anthony Liguori