From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MkuMZ-0005ij-V1
	for qemu-devel@nongnu.org; Tue, 08 Sep 2009 02:39:36 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MkuMV-0005fB-P6
	for qemu-devel@nongnu.org; Tue, 08 Sep 2009 02:39:35 -0400
Received: from [199.232.76.173] (port=35729 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MkuMV-0005f8-Mc
	for qemu-devel@nongnu.org; Tue, 08 Sep 2009 02:39:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25195)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MkuMU-00081I-K3
	for qemu-devel@nongnu.org; Tue, 08 Sep 2009 02:39:31 -0400
Received: from int-mx05.intmail.prod.int.phx2.redhat.com
	(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n886dTok016094
	for <qemu-devel@nongnu.org>; Tue, 8 Sep 2009 02:39:29 -0400
Message-ID: <4AA5FC1E.4090607@redhat.com>
Date: Tue, 08 Sep 2009 08:39:26 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] virtio-blk: add msi support.
References: <1250074044-24667-1-git-send-email-kraxel@redhat.com>
	<1252346258.3056.73.camel@blaa>
In-Reply-To: <1252346258.3056.73.camel@blaa>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark McLoughlin <markmc@redhat.com>
Cc: qemu-devel@nongnu.org

On 09/07/09 19:57, Mark McLoughlin wrote:
> On Wed, 2009-08-12 at 12:47 +0200, Gerd Hoffmann wrote:
>> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
>> ---
>>   hw/pc.c         |    4 ++++
>>   hw/virtio-pci.c |    8 ++++++--
>>   2 files changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/pc.c b/hw/pc.c
>> index cc6e7e8..cccb865 100644
>> --- a/hw/pc.c
>> +++ b/hw/pc.c
>> @@ -1487,6 +1487,10 @@ static QEMUMachine pc_machine_v0_10 = {
>>               .driver   = "virtio-net-pci",
>>               .property = "vectors",
>>               .value    = stringify(0),
>> +        },{
>> +            .driver   = "virtio-blk-pci",
>> +            .property = "vectors",
>> +            .value    = stringify(0),
>
> This means that MSI is enabled for virtio-blk with the pc-0.11 machine
> type.
>
> Shouldn't we add a pc-0.12 machine type and disable MSI for pc-0.11?

Either that or apply the virtio-blk msi patch to the stable-0.11 branch.

cheers,
   Gerd