From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MkuZW-0005D5-H0
	for qemu-devel@nongnu.org; Tue, 08 Sep 2009 02:52:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MkuZR-00057Q-QP
	for qemu-devel@nongnu.org; Tue, 08 Sep 2009 02:52:58 -0400
Received: from [199.232.76.173] (port=59843 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MkuZR-00057K-Jw
	for qemu-devel@nongnu.org; Tue, 08 Sep 2009 02:52:53 -0400
Received: from mx20.gnu.org ([199.232.41.8]:65294)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <kraxel@redhat.com>) id 1MkuZR-0001Bw-13
	for qemu-devel@nongnu.org; Tue, 08 Sep 2009 02:52:53 -0400
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MkuZQ-0004r9-4D
	for qemu-devel@nongnu.org; Tue, 08 Sep 2009 02:52:52 -0400
Message-ID: <4AA5FF3D.7010404@redhat.com>
Date: Tue, 08 Sep 2009 08:52:45 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/5] qdev: device capabilities
References: <1251714459-2467-1-git-send-email-kraxel@redhat.com>
	<4AA12D59.6040208@codemonkey.ws> <4AA12F46.6000207@redhat.com>
	<4AA26A2D.4010605@codemonkey.ws> <4AA4E4B9.4020208@redhat.com>
	<4AA56ECD.3040400@codemonkey.ws>
In-Reply-To: <4AA56ECD.3040400@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On 09/07/09 22:36, Anthony Liguori wrote:
> Gerd Hoffmann wrote:
>> Patch #5 does just that. Almost. -watchdog continues to accept
>> watchdog devices only. And '-watchdog ?' lists watchdog devices only.
>>
>> watchdog_list is gone, the qdev list is used instead. To identify the
>> watchdog devices in the qdev device model list the capability bit is
>> used. The patch description says so, doesn't it?
>
> Instead of checking the capability bit, why not look for a property with
> a type that's unique to the watch dog timer.

*There is no such property.*

We are running in circles for months now.  You are suggesting to look 
for a unique property.  I point out that it simply doesn't work for 
certain devices due to lack of such a property.  Repeat.

Can we stop that please?

Do you suggest to create some unused dummy property to tag devices?

thanks,
   Gerd