From: Anthony Liguori <anthony@codemonkey.ws>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] virtio-console: Have a static instance of virtconsole
Date: Tue, 08 Sep 2009 09:08:03 -0500 [thread overview]
Message-ID: <4AA66543.4000804@codemonkey.ws> (raw)
In-Reply-To: <1252055670-26958-1-git-send-email-amit.shah@redhat.com>
Amit Shah wrote:
> Currently the VirtIOConsole struct is allocated from the call
> to virtio_common_init, also doing an UP_CAST implicitly.
>
> The new multiport functionality will need a few arrays and
> it's easier to move to the new VMState infrastructure by
> keeping it all within one struct.
>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
>
This seems bad. Even though the device is multiport capable, we should
still supporting having multiple devices per guest.
I think Gerd would suggest this is a use-case for capabilities. I'm not
sure we have a similar device that can take multiple char drivers.
Maybe we ought to treat virtio-console like a bus? Do you have any
suggestions Gerd?
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-09-08 14:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 9:14 [Qemu-devel] [PATCH] virtio-console: Have a static instance of virtconsole Amit Shah
2009-09-04 16:26 ` Blue Swirl
2009-09-04 16:33 ` Amit Shah
2009-09-04 16:37 ` Blue Swirl
2009-09-04 16:40 ` Amit Shah
2009-09-04 16:45 ` Blue Swirl
2009-09-04 16:51 ` Amit Shah
[not found] ` <m3y6ouy5lq.fsf@neno.mitica>
2009-09-04 17:40 ` [Qemu-devel] " Amit Shah
2009-09-08 14:08 ` Anthony Liguori [this message]
2009-09-08 14:41 ` Gerd Hoffmann
2009-09-09 6:07 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA66543.4000804@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=amit.shah@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).