From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ml1Mk-0002Qk-AX
	for qemu-devel@nongnu.org; Tue, 08 Sep 2009 10:08:14 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Ml1Mg-0002QA-QQ
	for qemu-devel@nongnu.org; Tue, 08 Sep 2009 10:08:14 -0400
Received: from [199.232.76.173] (port=59396 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ml1Mg-0002Q7-Nn
	for qemu-devel@nongnu.org; Tue, 08 Sep 2009 10:08:10 -0400
Received: from qw-out-1920.google.com ([74.125.92.148]:21887)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Ml1Mf-00012z-2I
	for qemu-devel@nongnu.org; Tue, 08 Sep 2009 10:08:09 -0400
Received: by qw-out-1920.google.com with SMTP id 5so732968qwc.4
	for <qemu-devel@nongnu.org>; Tue, 08 Sep 2009 07:08:08 -0700 (PDT)
Message-ID: <4AA66543.4000804@codemonkey.ws>
Date: Tue, 08 Sep 2009 09:08:03 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1252055670-26958-1-git-send-email-amit.shah@redhat.com>
In-Reply-To: <1252055670-26958-1-git-send-email-amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] virtio-console: Have a static instance of
	virtconsole
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

Amit Shah wrote:
> Currently the VirtIOConsole struct is allocated from the call
> to virtio_common_init, also doing an UP_CAST implicitly.
>
> The new multiport functionality will need a few arrays and
> it's easier to move to the new VMState infrastructure by
> keeping it all within one struct.
>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
>   

This seems bad.  Even though the device is multiport capable, we should 
still supporting having multiple devices per guest.

I think Gerd would suggest this is a use-case for capabilities.  I'm not 
sure we have a similar device that can take multiple char drivers.

Maybe we ought to treat virtio-console like a bus?  Do you have any 
suggestions Gerd?

Regards,

Anthony Liguori